Strict type checking and py.typed #23
Open
+171
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Strict-type-checking-and-py.typed
branch
7 times, most recently
from
a07a320 to
f57c91c
Compare
Avasam
commented
Feb 8, 2025
Comment on lines
+187
to
+190
| _unicode_trap = ExceptionTrap(UnicodeDecodeError) # type: ignore[no-untyped-call] # jaraco/jaraco.context#15 | ||
|
|
||
|
|
||
| @_unicode_trap.passes | ||
| def is_decodable(value): | ||
| @_unicode_trap.passes # type: ignore[misc] # jaraco/jaraco.context#15 |
There was a problem hiding this comment.
Avasam
commented
Feb 8, 2025
| """ | ||
| >>> indent('foo') | ||
| ' foo' | ||
| """ | ||
| return prefix + string | ||
|
|
||
|
|
||
| class WordSet(tuple): | ||
| class WordSet(Tuple[str, ...]): |
There was a problem hiding this comment.
This class has a lot of methods that return WordSet or WordSet | Self, but it would somewhat trivial to update them to all return Self
Avasam
commented
Feb 8, 2025
| @@ -23,6 +30,7 @@ def report_newlines(filename): | |||
| count = len(tuple(always_iterable(newlines))) | |||
| engine = inflect.engine() | |||
| print( | |||
| # Pyright typing issue: jaraco/inflect#210 | |||
There was a problem hiding this comment.
Ref: jaraco/inflect#210
Avasam
force-pushed
the
Strict-type-checking-and-py.typed
branch
4 times, most recently
from
d15edbb to
b2b5e84
Compare
Avasam
force-pushed
the
Strict-type-checking-and-py.typed
branch
from
b2b5e84 to
ef07488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
Ref: jaraco/skeleton#143
This is one of the untyped libs used by setuptools.