Reduce allocations #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure of getting a `PortableExecutableReference` meant that we were essentially paying for `byte[]` twice. The first is generating the `byte[]` for the resource and then when that was passed to `CreateFromImage` it was converted to an `ImmutableArray<byte>` which means there is yet another `byte[]` allocation. To avoid this the code now just directly allocates the `ImmutableArray<byte>` and passes that to `CreateFromImage`. This can save up to 45MB in certain cases I was looking at in the Roslyn tests.
jaredpar
added a commit
to dotnet/roslyn
that referenced
this pull request
Sep 19, 2024
This updates the basic reference assemblies packages to a fix that removed a double allocation of `byte[]` when creating references jaredpar/basic-reference-assemblies#63
jaredpar
added a commit
to dotnet/roslyn
that referenced
this pull request
Sep 19, 2024
This updates the basic reference assemblies packages to a fix that removed a double allocation of `byte[]` when creating references jaredpar/basic-reference-assemblies#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure of getting a
PortableExecutableReferencemeant that we were essentially paying forbyte[]twice. The first is generating thebyte[]for the resource and then when that was passed toCreateFromImageit was converted to anImmutableArray<byte>which means there is yet anotherbyte[]allocation. To avoid this the code now just directly allocates theImmutableArray<byte>and passes that toCreateFromImage.This can save up to 45MB in certain cases I was looking at in the Roslyn tests.