Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite debug function to do pre_setup and post_teardown #94

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

tricosmo
Copy link
Contributor

Hi

As the problem is discribed there. pytest-dev/pytest#1932 (comment). I think this is maybe a worthy fix.

Sorry this is the first time I create a pull request, if any unclear, please let me know
Thanks.
Niansheng Liu

@makmanalp
Copy link

Bump - this is causing headaches for me too, and it took me a long while to track down because it breaks even the debugging and manifests in very odd ways.

The reasoning of the py.test folks seems reasonable - if you're going to override __call__ it makes sense that you should have to override other stuff to make sure the behavior is consistent, including debug() (docs here), which is basically the same thing as __call__ but calling a different function and not collecting the result. FWIW, the change has my 👍 .

@jcomo jcomo merged commit bc3994f into jarus:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants