Changing some prettyping errors to be able to ignore them (preparation to fix bug #727) #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDaiki
force-pushed
the
warning-pretyping
branch
2 times, most recently
from
71162f6 to
696df0c
Compare
vbgl
reviewed
Jan 24, 2025
CHANGELOG.md
Outdated
| @@ -35,6 +35,10 @@ | |||
| therefore old intrinsic `#VPBLENDVB` is deprecated | |||
| ([PR #1010](https://github.com/jasmin-lang/jasmin/pull/1010)). | |||
|
|
|||
| - Add an option to treat some pre-typing error as warning instead. | |||
| ([PR #1023](https://github.com/jasmin-lang/jasmin/pull/1023)) | |||
| fixes [#727](https://github.com/jasmin-lang/jasmin/issues/727). | |||
There was a problem hiding this comment.
I don’t think 727 is fixed yet. But this is indeed necessary preparatory work.
MrDaiki
force-pushed
the
warning-pretyping
branch
from
696df0c to
eab7123
Compare
MrDaiki
changed the title
MrDaiki
changed the title
MrDaiki
changed the title
MrDaiki
changed the title
MrDaiki
changed the title
…bal boolean, it is useful for experimentation purposes)
MrDaiki
force-pushed
the
warning-pretyping
branch
from
eab7123 to
38979db
Compare
vbgl
approved these changes
Jan 27, 2025
vbgl
pushed a commit
that referenced
this pull request
Jan 27, 2025
(cherry picked from commit c5d8a39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some well typed programs are rejecting by pre-typing because they don't have a valid assembly target (see #727)
Solution
I introduced a global boolean variable (I know it isn't the cleanest but it fit well in this case) that define if some of pre-typing error should be handled as warning or as error. It can be set with the
Utils.set_warn_recoverablefunction.