Fixing type checking of function return storage type #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDaiki
changed the title
vbgl
reviewed
Jan 28, 2025
MrDaiki
force-pushed
the
issue_18
branch
4 times, most recently
from
bb278f9 to
45f39ae
Compare
|
This unveils issues in the libjade source code. Unfortunately, the source code of libjade that we use in CI is a frozen snapshot. It is time to fix these libjade CI jobs. It might be possible to go in two steps: first make this a warning and later turn it into an error. |
|
Here is a fix for libjade: formosa-crypto/libjade#131 |
vbgl
force-pushed
the
issue_18
branch
2 times, most recently
from
a42781c to
f335eaa
Compare
eponier
approved these changes
Feb 12, 2025
|
Thanks for reviewing, polishing, and merging! |
vbgl
pushed a commit
that referenced
this pull request
Feb 12, 2025
Adding checking to function storage signature against inferred type signature (cherry picked from commit 73d0e83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Compiler wasn't checking coherence of storage types between declared return storage type and return variable storage type. For more informations see #18
Solution
Defining a new function in
pre-typingto check for this.Implication
This change break retrocompatibility making some old program not valid. (some tests of the test suite had to be modified)
Fixes #18