Get random2

[bgregoir]

Need to fix the ocaml part.

[bgregoir]

I'm done with this PR. It will be nice to review it.

[vbgl]

Can you please rebase to fix the conflicts? Thanks.

[bgregoir]

Merge done.
I have realized that one test did not pass.
I think the pb is that we need to link the syscall (I don't know how to do that).

[vbgl]

Libjade fails:

"…/libjade-main/src/crypto_kem/kyber/common/amd64/kem.jinc", line 46 (4-21)
from "kem.jazz", line 8 (2-38):
compilation error in function jade_kem_kyber_kyber512_amd64_avx2_keypair:
one-varmap checker: modified expression

cc @tfaoliveira

[tfaoliveira]

I will try to understand why this happens

[tfaoliveira]

The following program (similar to the usage in Kyber) fails:

param int KYBER_SYMBYTES = 32;

export fn test2(reg u64 skp)
{
  inline int i;
  stack u8[KYBER_SYMBYTES] rb;
  reg u64 t64;
  
  skp = skp;

  rb = #randombytes(rb);

  for i=0 to KYBER_SYMBYTES/8
  {
    t64 = rb[u64 i];
    (u64)[skp] = t64;
    skp += 8;
  }
}

with the error:

"test2.jazz", line 16 (4-21):
compilation error in function test2:
one-varmap checker: modified expression

Is there something wrong with it?

[vbgl]

Looks like a bug in this PR. I’ll try to understand.

[vbgl]

Fixed! Thanks Tiago for your help.

[tfaoliveira]

I'm compiling this branch to run some tests locally as well

[tfaoliveira]

It seems fine on my side: the checksums of the implementations match; I think I didn't miss anything.

[vbgl]

Great! I’ve also changed the tests a bit to avoid link failures in some environments.

[bgregoir]

Are we ready ?

[bgregoir]

The patch for the test works on my MAC

[vbgl]

This is a major, long-awaited, change!