checksafety: better handling of integer shift operators #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just rebased to fix the merge conflicts in the CHANGELOG. |
eponier
reviewed
Jan 10, 2023
Comment on lines
+117
to
+120
| | E.Olsl (Op_w _) -> AB_Wop (Wshift Unsigned_left) | ||
| | E.Olsl Op_int -> AB_Unknown | ||
| | E.Oasr (Op_w _) -> AB_Wop (Wshift Signed_right) | ||
| | E.Oasr Op_int -> AB_Unknown |
There was a problem hiding this comment.
Why do we need to distinguish Op_w and Op_int here? And not for other operations?
There was a problem hiding this comment.
I don’t know. Could you provide an example in which not doing this distinction is a problem?
There was a problem hiding this comment.
No, I'm trying to understand what you did.
There was a problem hiding this comment.
Anyway, this is stricter than before...
Comment on lines
+338
to
+342
| | Papp2 (Olsl Op_int, e1, e2) -> | ||
| obind2 zlsl | ||
| (aeval_cst_zint abs e1) (aeval_cst_zint abs e2) | ||
|
|
||
| | Papp2 (Oasr Op_int, e1, e2) -> |
There was a problem hiding this comment.
Why is there nothing for Olsr? Just not done yet?
This avoids a few crashes
eponier
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
(The first commit is unrelated, but it does not deserves a PR on its own.)
CI: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/738147944