Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM/lowering: High-level syntax for 32→64-bit multiplication #477

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Jun 13, 2023

This is much more complex than expected as the order of the destinations is different for the jasmin operator and the ARM instruction.

@vbgl vbgl added arm Related to the arm port lowering labels Jun 13, 2023
@vbgl vbgl marked this pull request as draft June 13, 2023 13:46
The definition of the UMUL instruction is slightly amended to write its
results in the same order as the Jasmin source semantics. The order is
irrelevant as the destination registers must be different.
@vbgl vbgl marked this pull request as ready for review June 13, 2023 15:02
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better like that :-)

@vbgl
Copy link
Member Author

vbgl commented Jun 13, 2023

Thanks for your help.

@bgregoir bgregoir merged commit d9d964d into main Jun 14, 2023
@bgregoir bgregoir deleted the arm-umull branch June 14, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Related to the arm port lowering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants