Improvements to the support of reg arrays #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to work correctly for reg ptr arrays, but incorrectly for reg ptr sub-arrays. Now, both are ignored.
eponier
force-pushed
the
reg-arr-export
branch
from
1b511b4 to
47f7887
Compare
|
(the last commit is unrelated, I wonder if in the first paragraph the most sensible thing to do would be to have the PR link at the end of the first sentence instead of at the end of the paragraph, but this is not important) |
bgregoir
previously approved these changes
Feb 8, 2024
vbgl
reviewed
Feb 9, 2024
|
I don’t like the last commit. |
+ add a lot of test cases
eponier
force-pushed
the
reg-arr-export
branch
from
47f7887 to
ecc9ab3
Compare
|
I dropped the last commit to avoid blocking the PR. |
vbgl
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, it fixes a bad interaction with reg ptr and turns most of the errors into non-internal ones.
Fixes #708