New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86: fix lowering of large immediate store #730

Merged

bgregoir merged 1 commit into main from x86-mov-large-imm-to-memory

Feb 16, 2024

Member

vbgl commented Feb 15, 2024

No description provided.


          x86: fix lowering of large immediate store

e1b5cce

vbgl added the lowering label

Contributor

bgregoir commented Feb 16, 2024 •

edited

Loading

Just a side note, I wonder if we should emit warning for this particular case.
imagine this code:
while (i < n) {
[p + i * 8 ] = 2u32[1,0];
i += 1;
}

many move will be introduced silently, while it is maybe better to move 2u32[1,0] one before the loop.
A warning can be welcome.

bgregoir approved these changes

View reviewed changes

bgregoir merged commit cfa8e72 into main

1 check passed

bgregoir deleted the x86-mov-large-imm-to-memory branch

February 16, 2024 13:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels