Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject ARM intrinsics with an S when they do not support it #809

Merged
merged 1 commit into from
May 27, 2024

Conversation

sarranz
Copy link
Collaborator

@sarranz sarranz commented May 24, 2024

Solves #808.

@vbgl
Copy link
Member

vbgl commented May 24, 2024

Does this deserve a changelog entry?

@sarranz sarranz force-pushed the arm-cannot-set-flag-mnemonics branch from 419f3de to be162fa Compare May 25, 2024 13:25
@sarranz
Copy link
Collaborator Author

sarranz commented May 25, 2024

I added an entry in the changelog, and updated the check-arm-m4 script. All the test cases I added were accepted by the compiler but rejected by the assembler so they wouldn't have caught this.

vbgl
vbgl previously approved these changes May 27, 2024
@vbgl vbgl force-pushed the arm-cannot-set-flag-mnemonics branch from be162fa to 00e6bc8 Compare May 27, 2024 09:32
@vbgl vbgl merged commit d6e672c into jasmin-lang:main May 27, 2024
1 check passed
@sarranz sarranz deleted the arm-cannot-set-flag-mnemonics branch November 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants