DOIT: update is_doit_asm_op in x86_arch_full.ml: IMUL* to true. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
approved these changes
Oct 14, 2024
vbgl
pushed a commit
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit 7d3697a)
sarranz
pushed a commit
to sarranz/jasmin
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates file
x86_arch_full.ml:to
As @vbgl noticed,
IMULrandIMULriare DOIT after I had an issue with a Poly1305 implementation.Is it worth to define a test for this change? I couldn't find related tests.