hack: expand snapshots inside docker #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaypipes and me talked a bit offline about how snapshots should look like, which the challenges are with symlinks, and in short why $ docker info
Client:
Context: default
Debug Mode: false
Plugins:
app: Docker App (Docker Inc., v0.9.1-beta3)
buildx: Build with BuildKit (Docker Inc., v0.5.0-docker)
Server:
Containers: 16
Running: 0
Paused: 0
Stopped: 16
Images: 96
Server Version: 20.10.1so let's discuss! worst case we can have a great reference to document why should NOT go this way :) |
ffromani
force-pushed
the
run-against-snapshot-updates
branch
from
0e004a4 to
c17aa01
Compare
|
and with my latest commit works as well with /usr/bin/podman version
Version: 2.2.1
API Version: 2.1.0 |
jaypipes
requested changes
Jan 5, 2021
SNAPSHOT.md
Outdated
| For GHW, snapshots are partial clones of the `/proc`, `/sys` (et. al.) subtrees taken into arbitrary | ||
| machines, which GHW can consume later. "partial" is because the snapshot doesn't need to contain a | ||
| complete copy of all the filesystem subtree (that is doable but inpractical). It only needs to contain | ||
| the paths GHW cares about. The snapshot concept was introduced [to make GHW easier to test](https://github.com/jaypipes/ghw/issues/66). |
GHW gained support to consume snapshot programmatically. This means there is no need anymore to expand the snapshot before mount it in docker, which greatly simplifies the `run-against-snapshot.sh` scripts. We just need to pass the snapshot and a bunch of environment variables. Additionally, start document describing how a GHW compliant snapshot should look like, and why things are the way they are. Signed-off-by: Francesco Romani <[email protected]>
add minimal changes to be able to use podman. Default is still docker. Example: CONTAINER_RUNTIME=podman ./hack/run-against-snapshot.sh ... Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
run-against-snapshot-updates
branch
from
c17aa01 to
4ca6c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHW gained support to consume snapshot programmatically.
This means there is no need anymore to expand the snapshot before
mount it in docker, which greatly simplifies the
run-against-snapshot.shscripts.We just need to pass the snapshot and a bunch of environment variables.
Additionally, start document describing how a GHW compliant snapshot
should look like, and why things are the way they are.
Signed-off-by: Francesco Romani [email protected]