PCI: Add device revision number #219
Conversation
Providing access to the revision number of hardware can be useful in identifying or diagnosing problems introduced across versions of single product line. Signed-off-by: Kevin Pearson <[email protected]>
|
|
||
| if _, err := os.Stat(revisionPath); err != nil { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
this is not wrong, but it seems we can just call ReadFile directly instead of checking with os.Stat before.
There was a problem hiding this comment.
I concur. I implemented it in this fashion to mirror the existing approach for reading the modalias file, for the sake of consistency. I'm not against the simplified approach of attempting a read and reacting on the returned error
There was a problem hiding this comment.
I don't have strong opinions here. Both approaches have their merits.
There was a problem hiding this comment.
yeah, totally fine to use existing pattern here.
| } | ||
| revisionPath := filepath.Join( | ||
| paths.SysBusPciDevices, | ||
| pciAddr.Domain+":"+pciAddr.Bus+":"+pciAddr.Slot+"."+pciAddr.Function, |
There was a problem hiding this comment.
this suggests we may want to add a String method to pci.Address (not in this PR)
|
/lgtm |
|
|
||
| if _, err := os.Stat(revisionPath); err != nil { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
yeah, totally fine to use existing pattern here.
Providing access to the revision number of hardware can be useful in
identifying or diagnosing problems introduced across versions of single
product line.
Signed-off-by: Kevin Pearson [email protected]