Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace strings.TrimPrefix with filepath.Rel #399

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Gofastasf
Copy link
Contributor

  • filepath.Rel to find relative path in platform aware way.
  • file closing by defer.

- filepath.Rel to find relative path in platform aware way.
- file closing by defer.
Copy link
Owner

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your PR, @Gofastasf ! :) Looks good to me!

@jaypipes jaypipes merged commit 10a347c into jaypipes:main Feb 2, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants