-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cleanup #134
Some cleanup #134
Conversation
@@ -27,7 +24,7 @@ | |||
USER_NATURAL_KEY = tuple(key.lower() for key in USER_NATURAL_KEY.split('.', 1)) | |||
|
|||
|
|||
class SimpleHistoryAdmin(admin.ModelAdmin): | |||
class SimpleHistoryAdmin(admin.ModelAdmin, object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the other object
inheritance doesn't make sense to me. admin.ModelAdmin
is a new-style class.
👍 except for the |
Landscape claimed they were old-object... I'll revert. Maybe it's a 2/3 thing. |
I think that for |
@dnozay as you can see from our code, we are using |
@macro1 |
this could be some issue in |
... subclasses. This is done by exposing a Manager object. see jazzband/django-simple-history#134 as well.
After I saw the Landscape badge @dnozay added, I decided to see if we could get a few of the issues addressed.
One thing I did that I'm not sure about is explicitly adding
object
as a base for the manager and admin classes to ensure they are new-type classes.