Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report exceptions that cause failures in testcases.docopt #35

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

h4l
Copy link
Contributor

@h4l h4l commented Aug 27, 2022

Currently only DocoptTestException is reported, no info on the error is shown if any other error is raised during a testcases.docopt test. This change delegates to the default pytest.Item error reporting implementation for non-docopt errors.

Currently only DocoptTestException is reported, other errors show no
information.
@NickCrews
Copy link
Contributor

I noticed this, but was too lazy to actually figure out the fix. That was easy, thank you1

I don't think this will cause merge conflicts with #36 🤞 , so merging this now

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #35 (691a840) into master (88496b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files           1        1           
  Lines         492      492           
=======================================
  Hits          491      491           
  Misses          1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickCrews NickCrews merged commit 744853c into jazzband:master Sep 7, 2022
@h4l
Copy link
Contributor Author

h4l commented Sep 8, 2022

Cool, thanks for merging! It was pleasantly straightforward to fix. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants