Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with search index that prevented incremental rebuilds #13

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

jbms
Copy link
Owner

@jbms jbms commented Oct 17, 2021

Fixes #12

@jbms jbms force-pushed the fix-search-index-rebuild-issue branch from 8e6ca23 to d8a5b49 Compare October 17, 2021 22:27
@jbms jbms merged commit b5948c7 into main Oct 17, 2021
@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 17, 2021

the build CI could be triggered for only PR opened events since any push also triggers a PR synchronize event (resulting in 2 runs for each commit when a PR is open)

on:
  pull_request:
    types: [opened, reopened]
  push:

@jbms jbms deleted the fix-search-index-rebuild-issue branch October 17, 2021 22:36
@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 17, 2021

Also, IDK if this is a high priority for you, but it seems the pypi token is invalid. I would greatly appreciate using a wheel from the test pypi server. Currently, I've been using a locally copied wheel for my RTD project, and I'd like to avoid that.

@jbms
Copy link
Owner Author

jbms commented Oct 17, 2021

I just pushed a PyPI package and added the token (you have to push an initial version manually before you can generate a token).

@2bndy5
Copy link
Collaborator

2bndy5 commented Oct 17, 2021

https://test.pypi.org/project/sphinx-immaterial/

pip install -i https://test.pypi.org/simple/ sphinx-immaterial

there's a space in the url which prevents using it in a requirements.txt file (I have tried using single and double quotes). Without the space, pip gets a 404. Without quotes, git clone errors out.


oh I see you pushed to regular pypi. That works just as well 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow consecutive builds
2 participants