Fix 168 #174
Merged
Fix 168 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parametrize graphviz tests fix type hint in test func obj ensure xref to py domain
|
If you have other comma-separated attributes next to it, does it work to remove the commas? |
Nevermind, I see that commas are optional. Looks good to me, thanks. |
|
Yeah, only the whitespace between attributes is important. I'll merge this and tag main with v0.10 because the code annotations feature is taking me longer to polish than I had hoped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #168
This basically removes the commas from the substituted attributes ( triggered by xref attribute) and adds a couple unit tests to make sure the dot executable doesn't error out.
I have also visually verified that the graphs generated in the test are as expected. There might be a better way to inspect the SVG output, but I'd prefer to do that with a generated SVG file; this theme's graphviz ext embeds SVG data directly into the HTML for good reasons.