add inline icon role and doc for it #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
reviewed
Nov 1, 2022
jbms
reviewed
Nov 1, 2022
jbms
reviewed
Nov 1, 2022
jbms
reviewed
Nov 1, 2022
jbms
reviewed
Nov 1, 2022
| - :md-icon:`octicons/mark-github-16` `Octicons <https://octicons.github.com/>`_ | ||
| - :md-icon:`simple/simpleicons` `Simple Icons <https://simpleicons.org/>`_ | ||
|
|
||
| You can also browse these icons locally from the sphinx-immaterial theme's install path under |
There was a problem hiding this comment.
I suppose we could integrate the "icon" index from mkdocs-material into our docs...
There was a problem hiding this comment.
Yeah, I thought about that too. This is something that can be addressed in the next merge from upstream, assuming we currently exclude the part of the build script that creates the json.
2bndy5
force-pushed
the
inline-icons
branch
2 times, most recently
from
e7f1b98 to
fb238d6
Compare
2bndy5
commented
Nov 1, 2022
jbms
reviewed
Nov 3, 2022
jbms
reviewed
Nov 3, 2022
jbms
reviewed
Nov 3, 2022
jbms
reviewed
Nov 3, 2022
|
Looks good to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to use a builtin icon or a project specific SVG (located in static folder) as an inline text element.