Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sphinx 8.2 #410

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Add support for Sphinx 8.2 #410

merged 2 commits into from
Feb 20, 2025

Conversation

jbms
Copy link
Owner

@jbms jbms commented Feb 20, 2025

This also changes the CI to use uv.

@jbms jbms force-pushed the uv branch 2 times, most recently from 0d08095 to b10a8c6 Compare February 20, 2025 01:35
@2bndy5
Copy link
Collaborator

2bndy5 commented Feb 20, 2025

Wow, uv added a lot more features since I last checked it out.

@jbms jbms force-pushed the uv branch 9 times, most recently from 0f45af1 to f5998d4 Compare February 20, 2025 06:16
This also changes the CI to use uv.

Fixes #409.
@2bndy5
Copy link
Collaborator

2bndy5 commented Feb 20, 2025

I recently also came across pixi, yet another project management tool written in rust with goals that overlap uv. Both are still in beta though. I'm kinda surprised you're migrating to uv, but I see cibuildwheel package is using uv under the hood now...

BTW, I've been using another tool written in rust to manage what node version I'm using for different projects: fnm.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 62.99213% with 47 lines in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (4f7e08e) to head (12e1a03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...symbol_resolution_through_type_aliases_sphinx81.py 62.50% 33 Missing ⚠️
sphinx_immaterial/apidoc/apidoc_formatting.py 36.84% 12 Missing ⚠️
...p_domain_symbol_resolution_through_type_aliases.py 80.00% 1 Missing ⚠️
sphinx_immaterial/apidoc/json/domain.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   82.12%   81.91%   -0.22%     
==========================================
  Files          68       69       +1     
  Lines        8678     8781     +103     
==========================================
+ Hits         7127     7193      +66     
- Misses       1551     1588      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbms
Copy link
Owner Author

jbms commented Feb 20, 2025

I recently also came across pixi, yet another project management tool written in rust with goals that overlap uv. Both are still in beta though. I'm kinda surprised you're migrating to uv, but I see cibuildwheel package is using uv under the hood now...

I hadn't heard of pixi --- but from a quick look it seems to have a lot of nice features. I see that it is conda-oriented but actually uses uv under the hood, at least for pypi dependencies.

Since we are publishing to pypi rather than conda I think uv is the right choice here, though.

BTW, I've been using another tool written in rust to manage what node version I'm using for different projects: fnm.

Yes, I've also been using that, much faster than nvm.

@jbms
Copy link
Owner Author

jbms commented Feb 20, 2025

CI passes now.

@jbms jbms merged commit 4a5a20a into main Feb 20, 2025
26 checks passed
@jbms jbms deleted the uv branch February 20, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants