Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): add has method to check for registration existence #119

Merged
merged 3 commits into from
Jan 28, 2019
Merged

feat(container): add has method to check for registration existence #119

merged 3 commits into from
Jan 28, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jan 28, 2019

There are scenarios where it is required to know if a registration already exists or it would be useful to know if a registration already exists to avoid overwrites or other modifications.

@coveralls
Copy link

coveralls commented Jan 28, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling feb934a on faustbrian:feat/has into 9643789 on jeffijoe:master.

@jeffijoe
Copy link
Owner

Hey Brian!

Thanks for the PR, but you can actually just do if ('theValue' in container.registrations). 😄

Co-Authored-By: faustbrian <[email protected]>
@jeffijoe jeffijoe merged commit bfd8223 into jeffijoe:master Jan 28, 2019
@faustbrian faustbrian deleted the feat/has branch January 28, 2019 10:10
@jeffijoe
Copy link
Owner

Released as 4.2, thanks!

@faustbrian
Copy link
Contributor Author

That was quick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants