Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix #225 with pathToFileURL (breaks tests) #226

Closed
wants to merge 2 commits into from

Conversation

slavb18
Copy link

@slavb18 slavb18 commented Feb 18, 2021

this change breaks test, only for consultation

● loadModules › registers loaded modules async when using native modules

expect(received).toBe(expected) // Object.is equality

Expected: 3
Received: 0

  60 |     const result = await loadModules(deps, 'anything', { esModules: true })
  61 |     expect(result).toEqual({ loadedModules: moduleLookupResult })
> 62 |     expect(Object.keys(container.registrations).length).toBe(3)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9fbd195 on slavb18:master into 7489ef5 on jeffijoe:master.

@slavb18
Copy link
Author

slavb18 commented Feb 18, 2021

This change does not fixes windows tests, what to do next?

@richardsimko
Copy link
Contributor

richardsimko commented Feb 19, 2021

I think if you re-write this function to check the platform and set the expected file path appropriately then that should fix the tests?

const lookupResultFor = (modules: any) =>

@jeffijoe
Copy link
Owner

Superseded by #227

@jeffijoe jeffijoe closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants