fix admin lookup condition #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
reviewed
Jun 27, 2021
Co-authored-by: Cody Robibero <[email protected]>
crobibero
approved these changes
Jun 27, 2021
h1dden-da3m0n
approved these changes
Jun 27, 2021
h1dden-da3m0n
added
the
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #57
I had the same problem as described in the issue and investigated it a little bit. I could clearly see in my OpenLDAP logs, that the Admin Query returned results, but the debug log message always showed
is admin? FalseAfter looking around in the LDAP Library documentation, I could not find a single reference that would confirm the current usage to be valid. Therefore I changed the condition based on the documented methods and now it's working.
If I'd have to take a guess, I'd say that this might've worked in earlier versions but doesn't anymore, and since this whole block is only triggered on user creation it was probably overlooked when upgrading the dependency.