fix: remaining type errors #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferferga
commented
Apr 12, 2023
Locales are fully typed now. Keep track of intlify/vue-i18n#1116 for better TS support for them - The rest of them are waiting for PRs at Vuetify's side, an SDK upgrade and a further investigation of our typed routes setup. - Deep type instantiation is also fixed.
unplugin-vue-router uses a different name generation for its routes, so the names didn't overlap beforehand
We're already pinned on ES2022, so we don't need the TODO comment
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
ThibaultNocchi
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locales are fully typed now. Keep track of intlify/vue-i18n#1116 for better TS support for them
The rest of them are waiting for PRs at Vuetify's side, an SDK upgrade and a further investigation of our typed routes setup
Deep type instantiation is also fixed