Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tools (helm, helmfile, helmplugins, sops) #961

Merged
merged 9 commits into from
Jan 2, 2024

Conversation

smerle33
Copy link
Contributor

as per #198

@smerle33 smerle33 marked this pull request as draft December 20, 2023 14:25
@lemeurherve
Copy link
Member

Nit for the PR title: "feat: add helm"

@smerle33 smerle33 changed the title feat(helm): add helm to the image feat: add helm Dec 20, 2023
@smerle33 smerle33 marked this pull request as ready for review December 21, 2023 07:59
@smerle33 smerle33 marked this pull request as draft December 21, 2023 08:05
@smerle33 smerle33 changed the title feat: add helm feat: add tools (helm, helmfile) Dec 21, 2023
@smerle33 smerle33 changed the title feat: add tools (helm, helmfile) feat: add tools (helm, helmfile, helmplugins, sops) Dec 22, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm plugin suggestions

@smerle33 smerle33 marked this pull request as ready for review January 2, 2024 08:43
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks failure are only on Windows which is not changed in this PR

@dduportal
Copy link
Contributor

You can merge when you want

@smerle33 smerle33 merged commit af8e073 into jenkins-infra:main Jan 2, 2024
@smerle33 smerle33 deleted the add/tools branch January 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants