Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 #35 #28 set/get master coverage by repo URL instead of PR URL #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

terma
Copy link
Contributor

@terma terma commented Oct 12, 2017

No description provided.

@terma terma changed the title #42 #35 #28 Store/Access master coverage by repo URL instead of PR UR… #42 #35 #28 set/get master coverage by repo URL instead of PR URL Oct 12, 2017
Copy link

@snadorp snadorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please merge.

@ayoub-benali
Copy link

are there any plans to get this fix merged ?

@AASyedAbbas
Copy link

Please merge the changes as it solves the problem which we are facing for long.

@rohitjha
Copy link

rohitjha commented Apr 5, 2018

@terma it'll be great if you can merge this and make a new release soon.

@gouraharidas
Copy link

When is this getting merged?

@killthemyth
Copy link

@terma Any plan for the merge?

@mahyarv
Copy link

mahyarv commented Jan 16, 2019

Will this get merged?

@terma
Copy link
Contributor Author

terma commented Jan 18, 2019

@mahyarv let me re-test it, and I will merge it

@adiesner
Copy link

adiesner commented Mar 25, 2019

For me this is still not the correct way to store the master coverage. As soon as you have multiple projects within one repository it always compares to the project that has the latest build.

Proposal:
Use: $GIT_REPOSITORY/$PATH_TO_PROJECT/$PATH_TO_COVERAGE_REPORTS
Alternative: $GIT_REPOSITORY/$CONFIGURABLE_PROJECT_NAME

On the screenshot below one pull request is affecting multiple of our projects in the same repository. When opening the pull request multiple projects in Jenkins start to build. As you can see the reference is always 62% (which is the coverage from the last project that built on master)
image

I am willing to contribute with a pull request to this issue, but this pull request has been open 1,5 years now. Will my contribution ever be merged?

@dmotpan
Copy link
Collaborator

dmotpan commented Mar 25, 2019

@adiesner yep, feel free, I will review it

Copy link

@sladyn98 sladyn98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1

@sladyn98
Copy link

sladyn98 commented Apr 3, 2020

@terma @dmotpan Is the maintenance of this plugin still active, because I was planning to develop an extension point to this to use in the Github Checks API Integration for jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.