Avoid UnsupportedOperationException in ZipPath#toFile with JDK 17
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ZipPath, toFile() is not possible and throws an exception. So we should not try to get the File of Paths but rather keep working with the Path This closes jenkinsci#160 Keep FileRecord for backwards-compatibility. Add test for zip-file walking Also verify that the correct type of object is registered as 'marker' by the instrumentation Add slightly more testing to check one unexpected file-handle leak that is reported Ignore closing of ZipFile/URLJarFile in tests Add one more test for Files.createTempFile()
Also add test for http-server setup
…peration_path_tofile
basil
changed the title
UnsupportedOperationException in ZipPath#toFile with JDK 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the list of kept open files from "File" to "Path" because File.toPath() can lead to UnsupportOperationException in some cases.
Additionally this enhances output and JavaDoc in a few places.
Fixes #160
Testing done
Submitter checklist