-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass minimumJavaVersion to RunMojo so that hpi:run works again #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though the test automation approach does not look to be very reliable
Well the test fails with the observed error when the fix is commented out, and passes with the fix in place. Do you have a better idea? |
Or hangs when something goes wrong. But I am OK with that, this component does not have a huge traffic |
Hmm
is something I do not get locally. |
Ah, the test fails when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this test on a master would have been fun.
Corrects a regression in #75, noticed in jenkinsci/external-monitor-job-plugin#18.