Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass minimumJavaVersion to RunMojo so that hpi:run works again #88

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 14, 2018

Corrects a regression in #75, noticed in jenkinsci/external-monitor-job-plugin#18.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though the test automation approach does not look to be very reliable

@jglick
Copy link
Member Author

jglick commented Dec 14, 2018

the test automation approach does not look to be very reliable

Well the test fails with the observed error when the fix is commented out, and passes with the fix in place. Do you have a better idea?

@oleg-nenashev
Copy link
Member

Well the test fails with the observed error when the fix is commented out, and passes with the fix in place. Do you have a better idea?

Or hangs when something goes wrong.

But I am OK with that, this component does not have a huge traffic

@jglick
Copy link
Member Author

jglick commented Dec 14, 2018

Hmm

org.apache.maven.plugin.MojoExecutionException: Error preparing the manifest: /var/jenkins_home/plugins/parent-3x.hpl (No such file or directory)
    at org.jenkinsci.maven.plugins.hpi.HplMojo.execute (HplMojo.java:108)
    at org.jenkinsci.maven.plugins.hpi.RunMojo.generateHpl (RunMojo.java:480)
    at org.jenkinsci.maven.plugins.hpi.RunMojo.execute (RunMojo.java:329)

is something I do not get locally.

@jglick
Copy link
Member Author

jglick commented Dec 14, 2018

Ah, the test fails when the JENKINS_HOME environment variable is set…

@jglick jglick requested a review from oleg-nenashev December 14, 2018 16:26
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this test on a master would have been fun.

@jglick jglick merged commit c7ac262 into jenkinsci:master Dec 14, 2018
@jglick jglick deleted the RunMojo.minimumJavaVersion branch December 14, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants