Trace Stapler request processing #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
3b3105f (plus a local |
jglick
previously requested changes
Oct 11, 2018
| private static List<ApplicationTracer> getTracers() { | ||
| if (tracers == null) { | ||
| synchronized (ApplicationTracer.class) { | ||
| if (tracers == null) { |
There was a problem hiding this comment.
Double-checked locking. Delete the outer null check.
jglick
reviewed
Oct 11, 2018
| } | ||
| } | ||
|
|
||
| private static volatile List<ApplicationTracer> tracers; |
There was a problem hiding this comment.
Pointless for this to be volatile, since you have the synchronized block.
| tracers = t; | ||
| } | ||
| } | ||
| return tracers; |
There was a problem hiding this comment.
This should really be inside the synchronized block. I think it is harmless to have it outside, since there will be a synchronization barrier before, but definitely not the best style.
| private static List<ApplicationTracer> getTracers() { | ||
| synchronized (ApplicationTracer.class) { | ||
| if (tracers == null) { | ||
| List<ApplicationTracer> t = new ArrayList<>(); |
There was a problem hiding this comment.
You do not need a separate variable. You can initialize tracers directly, since it is protected by a synchronization barrier.
|
FTR all you need is something like: private static List<X> xs;
static synchronized List<X> xs() {
if (xs == null) {
xs = new ArrayList<>();
// populate xs
}
return xs;
}Simple and safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream from jenkinsci/jenkins#3688