Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #95

Merged
merged 4 commits into from
Dec 25, 2016
Merged

Changelog #95

merged 4 commits into from
Dec 25, 2016

Conversation

vivek
Copy link
Contributor

@vivek vivek commented Dec 22, 2016

@daniel-beck
Copy link
Member

As I wrote in the other PR, it…

updates from 1.243 to 1.246, not from 1.244. Full list:

#73
#75
#77
#78
#79
#80

Also, that merge introduced a regression which resulted in 1.247 and 1.248.

So whatever this PR does, it's not even close to a recent changelog.

@vivek
Copy link
Contributor Author

vivek commented Dec 22, 2016

@daniel-beck Added change logs from 1.243 till 1.248. Please take a look.

@oleg-nenashev
Copy link
Member

I doubt the rendering is an expected one. It's hard to understand it

screen shot 2016-12-22 at 15 25 37

@vivek
Copy link
Contributor Author

vivek commented Dec 22, 2016

Go thru linked PRs and issues to get full understanding. This is summry it's unreasonable to expect to get full understanding of each or just from a sentence or two.

@oleg-nenashev
Copy link
Member

I just say the layout is barely readable, I do not request more details in the changelog itself

@vivek
Copy link
Contributor Author

vivek commented Dec 22, 2016

@oleg-nenashev Made some adjustments, please take a look.

@oleg-nenashev
Copy link
Member

LGTM 👍

@vivek
Copy link
Contributor Author

vivek commented Dec 25, 2016

@oleg-nenashev process wise, I wait for another LGTM or its good for merging? CI is failing but thats unrelated, this PR has no code changes.

@oleg-nenashev
Copy link
Member

I think it's fine to merge since the current changelog provides valuable information. If there any additional fixes, we can add changes in follow-up PRs.

@vivek vivek merged commit 7065a60 into jenkinsci:master Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants