build: Install to system's path (prefixed by destdir) #1923

rzr · 2019-07-16T12:44:37Z

This was introduced first in #1134 and then droped in #1848

This will be helpful for packaging,
or example on Tizen install using RPM macro: "%make_install"
of Debian's debhelper.

Work along CMAKE_INSTALL_PREFIX,
or/and can be overloaded individualy to alternate locations.

Forwarded: https://github.com/Samsung/iotjs/pull/
Relate-to: #1134
Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Forwarded: jerryscript-project#1923 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

daeyeon · 2019-07-25T06:40:59Z

The install dir of lib on the else branch is different.
In my second thought, using constant normal names (e.g: lib and bin) along with CMAKE_INSTALL_PREFIX looks enough.
The paths for lib and bin are editable but not for include.
INSTALL_PREFIX can be removed if CMAKE_INSTALL_PREFIX is guided.

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Forwarded: jerryscript-project#1923 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

This change is useful for debian packaging Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected] Update: 2020-07-24

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

cmake/iotjs.cmake

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

rzr · 2020-10-15T16:07:41Z

Please first merge:
#1948

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then droped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Update: 2020-07-24 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

rzr · 2020-10-16T12:25:24Z

unsure this failure is related to this change:
https://travis-ci.org/github/jerryscript-project/iotjs/jobs/736333817

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Gbp-Pq: Name 0001-iotjs-Install-binaries-to-system-1134.patch Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

rzr · 2020-10-21T02:09:22Z

This change is released in:
https://tracker.debian.org/news/1184873/accepted-iotjs-10715-1-source-into-unstable/

akosthekiss

Currently, there are two commits in this PR. Please, squash them.

cmake/iotjs.cmake

akosthekiss · 2020-12-21T12:20:15Z

OK, I just realized that the second commit may not belong to this here at all but could have infiltrated this PR from #1948 . That's not good either. This PR should contain the relevant commit only.

LaszloLango · 2021-05-12T08:19:46Z

@rzr #1948 is landed, please rebase this PR.

P.S.: sorry about the slow response times, this repository is not very active these days. :(

Install directory is prefixed by destdir to install in staging directory. This change is useful for debian packaging. Runtime destination rely on RUNTIME_OUTPUT_DIRECTORY property This was introduced first in jerryscript-project#1134 and then dropped in jerryscript-project#1848 This will be helpful for packaging, or example on Tizen install using RPM macro: "%make_install" of Debian's debhelper. Work along CMAKE_INSTALL_PREFIX, or/and can be overloaded individualy to alternate locations. Email has been updated for community support. Forwarded: jerryscript-project#1923 Bug: jerryscript-project#1945 Relate-to: jerryscript-project#1134 Change-Id: Ib969a1d5c2e7bc402b455377fc57a94654aa74dc Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/review/install/master Bug-Debian: https://bugs.debian.org/957364 Gbp-Pq: Name 0001-iotjs-Install-binaries-to-system-1134.patch Update: 2020-10-16 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval [email protected]

rzr · 2021-05-13T06:52:26Z

Hi, I've rebased it if It's merged i will rebase debian version on this base.

Next it will be helpful to update jerryscript with this additional change in:
jerryscript-project/jerryscript#4667

LaszloLango

LGTM

rzr · 2021-05-17T11:35:40Z

Thanks for feedback , anyone available to review and merge this one and then I'll update the debian package

Cc: @akosthekiss , @zherczeg , @daeyeon , @galpeter, @yadd ...

zherczeg

LGTM

zherczeg · 2021-05-17T15:37:12Z

Note: there is a change request, until that is resolved, this cannot be landed by github

rzr · 2021-05-17T22:05:42Z

OK, I just realized that the second commit may not belong to this here at all but could have infiltrated this PR from #1948 . That's not good either. This PR should contain the relevant commit only.

yes that's why I suggested to review the other one 1st
now it's merged and the relevant commit is right base...

Please can anyone ping @akosthekiss to unblock this ?

galpeter · 2021-06-17T15:34:08Z

cmake/iotjs.cmake

-  message(STATUS "LIBRARY_INSTALL_DIR     ${INSTALL_PREFIX}/lib")
+  message(STATUS "BINARY_INSTALL_DIR      ${INSTALL_PREFIX}/${BIN_INSTALL_DIR}")
+  message(STATUS "LIBRARY_INSTALL_DIR     ${INSTALL_PREFIX}/${LIB_INSTALL_DIR}")
+  message(STATUS "INCLUDE_INSTALL_DIR     ${INSTALL_PREFIX}/${INC_INSTALL_DIR}")


Shouldn't we replace the INSTALL_PREFIX with CMAKE_INSTALL_PREFIX ?

Can CMAKE_INSTALL_PREFIX be changed in cmake files I thought it was a configuration to be used from the outside (on cmake invocation)...

My install files relies on debhelper DESTDIR there is no need tweak:

https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX.html

For the record INSTALL_PREFIX was introduced in 99ec371 may this be changed in other change ?

So the main thing in this PR would be the new INC_INSTALL_DIR variable? If so I'm fine with this change. We'll adapt the INSTALL_PREFIX later on.

So the main thing in this PR would be the new INC_INSTALL_DIR variable? If so I'm fine with this change.

Thanks the problem is that it's blocked by @akosthekiss change request which can be only acknowledged by himself but I am not able to reach him, can anyone help ?

@akosthekiss was requested for review

akosthekiss

LGTM

rzr · 2021-06-18T09:43:47Z

I guess this can be now merged thx

rzr force-pushed the sandbox/rzr/review/install/master branch from e0bf1d8 to 4308e5f Compare July 16, 2019 12:44

rzr force-pushed the sandbox/rzr/review/install/master branch from 4308e5f to 830411f Compare July 23, 2019 17:47

rzr force-pushed the sandbox/rzr/review/install/master branch from 830411f to c24eb7b Compare July 24, 2019 07:56

rzr force-pushed the sandbox/rzr/review/install/master branch from c24eb7b to c75bd95 Compare May 29, 2020 07:55

rzr force-pushed the sandbox/rzr/review/install/master branch from c75bd95 to 344912f Compare July 23, 2020 23:48

rzr force-pushed the sandbox/rzr/review/install/master branch from 344912f to 01bca79 Compare July 24, 2020 08:47

rzr force-pushed the sandbox/rzr/review/install/master branch from 01bca79 to 2038ec7 Compare July 29, 2020 08:15

akosthekiss reviewed Jul 31, 2020

View reviewed changes

cmake/iotjs.cmake Show resolved Hide resolved

rzr mentioned this pull request Oct 15, 2020

debian packaging [meta] #1945

Open

rzr force-pushed the sandbox/rzr/review/install/master branch from 2038ec7 to 1271496 Compare October 15, 2020 16:48

rzr force-pushed the sandbox/rzr/review/install/master branch from 1271496 to d6bb818 Compare October 16, 2020 10:29

rzr force-pushed the sandbox/rzr/review/install/master branch from d6bb818 to 22167a7 Compare October 16, 2020 11:23

rzr force-pushed the sandbox/rzr/review/install/master branch from 22167a7 to e8bfdef Compare October 16, 2020 13:47

akosthekiss requested changes Dec 21, 2020

View reviewed changes

cmake/iotjs.cmake Show resolved Hide resolved

rzr mentioned this pull request Dec 21, 2020

build: Install static lib #1948

Merged

rzr force-pushed the sandbox/rzr/review/install/master branch from e8bfdef to 7e7c78a Compare May 12, 2021 08:26

LaszloLango approved these changes May 13, 2021

View reviewed changes

zherczeg approved these changes May 17, 2021

View reviewed changes

rzr requested a review from akosthekiss May 17, 2021 16:22

galpeter reviewed Jun 17, 2021

View reviewed changes

akosthekiss approved these changes Jun 18, 2021

View reviewed changes

akosthekiss merged commit 02599f3 into jerryscript-project:master Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Install to system's path (prefixed by destdir) #1923

build: Install to system's path (prefixed by destdir) #1923

rzr commented Jul 16, 2019

daeyeon commented Jul 25, 2019

rzr commented Oct 15, 2020

rzr commented Oct 16, 2020

rzr commented Oct 21, 2020

akosthekiss left a comment

akosthekiss commented Dec 21, 2020

LaszloLango commented May 12, 2021

rzr commented May 13, 2021

LaszloLango left a comment

rzr commented May 17, 2021

zherczeg left a comment

zherczeg commented May 17, 2021

rzr commented May 17, 2021 •

edited

Loading

galpeter Jun 17, 2021

rzr Jun 17, 2021 •

edited

Loading

galpeter Jun 17, 2021

rzr Jun 17, 2021 •

edited

Loading

galpeter Jun 17, 2021 •

edited

Loading

akosthekiss left a comment

rzr commented Jun 18, 2021

build: Install to system's path (prefixed by destdir) #1923

build: Install to system's path (prefixed by destdir) #1923

Conversation

rzr commented Jul 16, 2019

daeyeon commented Jul 25, 2019

rzr commented Oct 15, 2020

rzr commented Oct 16, 2020

rzr commented Oct 21, 2020

akosthekiss left a comment

Choose a reason for hiding this comment

akosthekiss commented Dec 21, 2020

LaszloLango commented May 12, 2021

rzr commented May 13, 2021

LaszloLango left a comment

Choose a reason for hiding this comment

rzr commented May 17, 2021

zherczeg left a comment

Choose a reason for hiding this comment

zherczeg commented May 17, 2021

rzr commented May 17, 2021 • edited Loading

galpeter Jun 17, 2021

Choose a reason for hiding this comment

rzr Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

galpeter Jun 17, 2021

Choose a reason for hiding this comment

rzr Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

galpeter Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

akosthekiss left a comment

Choose a reason for hiding this comment

rzr commented Jun 18, 2021

rzr commented May 17, 2021 •

edited

Loading

rzr Jun 17, 2021 •

edited

Loading

rzr Jun 17, 2021 •

edited

Loading

galpeter Jun 17, 2021 •

edited

Loading