Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target System.Text.Json 5.0.0 final #66

Merged
merged 18 commits into from
Sep 9, 2021
Merged

Target System.Text.Json 5.0.0 final #66

merged 18 commits into from
Sep 9, 2021

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Sep 9, 2021

Update FsCodec.SystemTextJson to use 5.0.0 final
Updated build and projects to rely on 5.0.200 SDK (local build works on my Mac from command line and Rider with only that)

@bartelink bartelink changed the base branch from master to v0 September 9, 2021 12:18
@bartelink bartelink changed the base branch from v0 to master September 9, 2021 12:18
@bartelink bartelink changed the title Target net5.0 Target System.Text.Json 5.0 final Sep 9, 2021
@bartelink
Copy link
Collaborator Author

@klimisa I have no idea what I did, but it seems this works in latest Rider on a Mac with only the 5.0 SDK installed
I've killed an old branch I had; Probably best to close #56 now ? (if you have time, would be good to check it's all happy of course!)

@klimisa
Copy link
Contributor

klimisa commented Sep 9, 2021

Let me have a look now!

PS: sorry for not being active, it have been a busy and it's still is.

@klimisa
Copy link
Contributor

klimisa commented Sep 9, 2021

All works fine on Linux!!!

Rider :
image

Shell:
image

cc/ @bartelink

@bartelink
Copy link
Collaborator Author

bartelink commented Sep 9, 2021

Thanks for validating @klimisa
Will merge now.

I'm thinking I'll release it as V 2.2.1, though arguably it merits a bigger increment. I guess it definitely will when I get bored of looking at #59 :D

@bartelink bartelink changed the title Target System.Text.Json 5.0 final Target System.Text.Json 5.0.0 final Sep 9, 2021
@bartelink bartelink merged commit b88959f into master Sep 9, 2021
@bartelink bartelink deleted the net5 branch September 9, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants