CosmosStore cleanup notably AsyncSeq #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #243 that contains cleanup work in
CosmosStore.fsextracted from #238 and #197 :AsyncSeqto manage encapsulation of paged reading (Cosmos SDK V4 introducesIAsyncEnumerablesupport, and this also simplifies the code absent of that)QueryRetryPolicy(doesn't make sense; will be replaced with mechanism @ylibrach introduced in feat!(CosmosStore): Azure.Cosmos 'V4' support / enable mocking Cosmos APIs #197)Also contains some stragglers regarding consistent naming etc from #243