[nix] Add DetSys installer behind feature flag #2303
Conversation
| // Should we pin version? Or just trust detsys | ||
| installScript = "curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix | sh -s -- install" | ||
| if isLinuxWithoutSystemd() { | ||
| installScript += " linux --init none" |
There was a problem hiding this comment.
I presume this is to manage the nix daemon.
How does the nix daemon get started without this?
There was a problem hiding this comment.
My understanding from the DetSys docs is that this makes it root only but will still work.
There are a few alternatives to this:
- Warn and give user options (e.g. install systemd or use new
--root-only) - Warn and install anyway
There was a problem hiding this comment.
Seems like they'll then need to run sudo to run devbox. I think emitting a warning (with a suggestion to install systemd and re-using the detsys installer manually) and continuing to install seems okay to minimize friction. WDYT?
There was a problem hiding this comment.
Not quite, user needs sudo only if not root, so at least some cases (e.g. ubuntu dockerfile) work pretty well as is.
That said, printing a message is very low friction. I'm not 100% sure re-running detsys installation would fix it, I need to experiment a bit more.
Summary
How was it tested?
devbox setup nixin linux docker container.