Apply fixes found in the result cache #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to apply fixes from errors found in the result cache. That means that even if we reuse the cache for a given module, we will try to find fixes. This is annoying for performance, but (so far at least) necessary because when the cache comes directly from the file system, we have never gone through the errors.
Basically, this PR solves the following issue:
While developing this change, I created additional bugs because I forgot to update the
ContentHash
inProjectModule
(which happen to never cause problems, I think, before this change). To prevent this from happening again, I madeProjectModule
opaque.