-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo-ize #164
Turbo-ize #164
Conversation
TS 5.5 infers predicates when they're more explicit.
Bumps everything but Jest to the latest version supporting Node 16.
Node 14 is required now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I'm willing to try turbo
out.
Can you tell me where I can find the docs for turbo? I'm having trouble finding it.
It's at https://turbo.build/repo/docs
I kept getting confused because I though turbo
was a different tool than turborepo
.
Do you also know if there's a way to not have the interactive window showing up? Mostly out of curiosity.
npm-run-all kept acting up
Do you remember what kind of problems you were encountering?
@@ -9,16 +9,13 @@ | |||
"packageManager": "[email protected]", | |||
"scripts": { | |||
"elm-format": "elm-format --validate ast-codec init-templates new-package parseElm review template", | |||
"test": "npm-run-all --print-name --silent elm-tests elm-format tsc eslint-check prettier-check test-run", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if it's possible to keep a test script so that I can just run npm test
?
Yeah. turbo is the cli, which came first. Then they made turbopack, so they retroactively named it turborepo, but they share a cli (well, they will eventually).
The
It wasn't injecting node_modules/.bin into the path, so some tests were failing.
Yeah. I can rename |
I think this would be great. I've pushed the change now 👍 |
If you prefer the log-order flags, I just found out you can set an env variable: |
Depends on #163
Relates to #156
npm-run-all kept acting up, so I went ahead and migrated elm-review to turbo.
Key things: everything is parallelized now. It's also cached.
To run tasks, use
turbo ...
instead ofnpm run ...
, which is installable vianpm install -g turbo
You can also use
npx turbo
. They both run using our pinned turbo, the global one just proxies to the local one.And, of course, you can still run
npm run ...
, it just won't get cached.If you want to add a task, just add it in the package.json. It'll automatically get cached. If you find it gets invalidated too much, you can add it to
turbo.json
.Here's the diff as GH doesn't play well with stacks from forks: lishaduck/node-elm-review@bump-deps-2...turbo
I also updated CI. I hope you don't mind.