Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates and rebase #2

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Updates and rebase #2

merged 13 commits into from
Jul 12, 2024

Conversation

BMurri
Copy link

@BMurri BMurri commented Jul 12, 2024

No description provided.

@BMurri BMurri changed the title Updates Updates and rebase Jul 12, 2024
@BMurri
Copy link
Author

BMurri commented Jul 12, 2024 •
edited
Loading

Regarding the removal of the ? nullability marks, I greatly prefer them, but our codebase is old and we haven't migrated this feature (which is now default for new projects) into our older projects yet, and leaving the build warnings in is more problematic than restoring them later.

Note that is on a project-by-project. Several of the projects in our two repos do have nullability turned on, and there the marks are hugely welcomed.

@jgainerdewar jgainerdewar merged commit 86d2563 into jgainerdewar:jgd_WX-1594 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BMurri @jgainerdewar