chore: fix auth flow #109
Merged
chore: fix auth flow #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfaultdoc
force-pushed
the
seg/auth-fix
branch
6 times, most recently
from
30b7705 to
09cbab8
Compare
segfaultdoc
force-pushed
the
seg/auth-fix
branch
from
09cbab8 to
53f6ca9
Compare
whistlinwilly
approved these changes
Aug 15, 2022
buffalu
reviewed
Aug 16, 2022
buffalu
reviewed
Aug 17, 2022
segfaultdoc
force-pushed
the
seg/auth-fix
branch
from
24e55fc to
d5ef55b
Compare
buffalu
reviewed
Aug 17, 2022
| ) -> (Arc<Mutex<Token>> /* access_token */, JoinHandle<()>) { | ||
| let rt = Runtime::new().unwrap(); | ||
|
|
||
| let (access_token, refresh_token) = { |
There was a problem hiding this comment.
this will block forever if we can't connect to auth, which i think will stop the rest of the validator from starting
There was a problem hiding this comment.
what if we pass the access token into this method and spin it up right away?
or do auth refresh inline with the rest of the work so it's not a separate thread
buffalu
pushed a commit
that referenced
this pull request
Mar 17, 2024
buffalu
pushed a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.