Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumb Terminal combined with AnsiConsole neglects possible stdout/stderr redirects #1160

Closed
cstamas opened this issue Jan 22, 2025 · 0 comments · Fixed by #1161
Closed

Dumb Terminal combined with AnsiConsole neglects possible stdout/stderr redirects #1160

cstamas opened this issue Jan 22, 2025 · 0 comments · Fixed by #1161
Labels
bug

Comments

@cstamas
Copy link
Contributor

cstamas commented Jan 22, 2025

In Maven4, we create Terminal (dumb) and install AnsibleConsole (with AnsiConsole.setTerminal(terminal) and then AnsiConsole.systemInstall()).

This causes that AnsibleConsole (due dumb terminal, isatty=false) always grab FileDescriptor.out instead of (potentially) redirected System.out.
@cstamas cstamas mentioned this issue Jan 22, 2025
Closed
cstamas added a commit to cstamas/jline3 that referenced this issue Jan 23, 2025
@cstamas
bug: Obey terminal if set
877dbb7 
Currently, if terminal is set, but is not "tty" (ie. is dumb),
AnsiConsole will grab the process stdout/stderr instead to obey
the set terminal output.

Fixes jline#1160
@cstamas cstamas mentioned this issue Jan 23, 2025
Merged
gnodet pushed a commit that referenced this issue Jan 24, 2025
@cstamas
AnsiConsole should always obey the terminal (fixes #1160) (#1161)
f869217 
* bug: Obey terminal if set

Currently, if terminal is set, but is not "tty" (ie. is dumb),
AnsiConsole will grab the process stdout/stderr instead to obey
the set terminal output.

Fixes #1160
@gnodet gnodet added the bug label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AnsiConsole should always obey the terminal (fixes #1160) cstamas/jline3
2 participants
@cstamas @gnodet