Inserting an image from a domain that's not github #50
Comments
|
Just tested this locally. Seems to be working now. Probably had something to do with the binary file fix. Try pulling the latest (or upgrading to grip 2.1 once it's released), and let me know if you're still having problems with this. |
joeyespo
added a commit
that referenced
this issue
Jul 27, 2014
The problem appears to be that GitHub replaces all external images with a cache stored on their servers. When using the Markdown API, these image URLs are still replaced, but image doesn't always resolve. The effect is that sometimes images are shown, and sometimes not. This is probably why #50 appeared to be resolved. This fix makes sure the image is shown from the source, so it'll always resolve (as long as it still exists on the original servers). A slightly better fix would be to only handle images that error out, but that optimization will be in a future fix.
|
Recently noticed this happening to me too. It seems the Markdown API still returns a cache URL, but the URL doesn't always resolve to an image. (Perhaps the API doesn't trigger the cache to re-fetch the image when it's out of date?) This is officially fixed in 77267ce by using the canonical image URL for all images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How do I modify the config to allow inserting images which are not hosted on github?
For example:
Does not work:
Works fine:
The text was updated successfully, but these errors were encountered: