Record hashing perf #781
Merged
Record hashing perf #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hashRecords=falsenarrative at https://github.com/johnkerl/miller/blob/main/internal/pkg/types/mlrmap.go#L1-L52 has been in place ever since the start of Miller in 2015 -- through the C implementation and the Go port as well.On #779 (https://github.com/johnkerl/miller/blame/main/internal/pkg/types/mlrmap.go#L61) two days ago I left
hashRecords=trueexperimentally for a while. However I find that I can't produce (yet) situations wherehashRecords=falseisn't faster. Performance improvement ranges from 5% to 40% for performance tests here, here, and here.So, experiment complete -- I'm going back to the historical (and well-reasoned) behavior, and documenting it for future reference.
(For reference, this PR was incorrectly rebased -- of the 31 commits on this PR, only the last one -- 447f139 -- is new.)