Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments from minified scripts. #105

Closed

Conversation

gwer
Copy link

@gwer gwer commented Mar 9, 2016

It reduces files size almost twice.

@prdolmos
Copy link

This needs rebasing

@shawnbot
Copy link
Collaborator

shawnbot commented Aug 8, 2016

Hey @gwer, I rebuilt this locally and pushed to this branch. Feel free to do the same on this branch and I can merge this PR; otherwise, I'll close this one and merge your commit via a new one.

@shawnbot
Copy link
Collaborator

shawnbot commented Aug 8, 2016

Also, thank you! This is long overdue.

It reduces files size almost twice.
@gwer gwer force-pushed the feature/remove_comments_from_minified branch from 95a656a to 59175cf Compare August 8, 2016 20:00
@gwer
Copy link
Author

gwer commented Aug 8, 2016

I'm sorry for your waiting.
I did rebase and build new files for dist.

@shawnbot
Copy link
Collaborator

shawnbot commented Aug 8, 2016

No problem, @gwer! When I said "this is long overdue," I was referring to the removal of comments from the minified builds; not your rebase. I'll get this merged and put out a new release soon! 🍻

@shawnbot
Copy link
Collaborator

Closing in favor of #123 because that one minifies even further by mangling variable names. Thank you for looking into this, @gwer!

@shawnbot shawnbot closed this Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants