Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of Hasbrown #183 "Avoid closures to improve compile times" #14

Merged
merged 6 commits into from
Aug 9, 2020
Merged

Port of Hasbrown #183 "Avoid closures to improve compile times" #14

merged 6 commits into from
Aug 9, 2020

Conversation

mucinoab
Copy link
Contributor

@mucinoab mucinoab commented Aug 9, 2020

This is the PR. I think I got everything in but let me know of any thoughts you may have.

@codecov-commenter
Copy link

Codecov Report

Merging #14 into master will decrease coverage by 0.19%.
The diff coverage is 77.27%.

Impacted Files Coverage Δ
src/set.rs 59.23% <33.33%> (-1.44%) ⬇️
src/map.rs 68.29% <88.57%> (+0.57%) ⬆️
src/external_trait_impls/rayon/map.rs 81.37% <0.00%> (-0.69%) ⬇️
src/external_trait_impls/rayon/set.rs 99.07% <0.00%> (-0.47%) ⬇️
src/external_trait_impls/rayon/helpers.rs 100.00% <0.00%> (ø)
src/raw/mod.rs 73.42% <0.00%> (+0.45%) ⬆️

@jonhoo
Copy link
Owner

jonhoo commented Aug 9, 2020

Ah, this is great, thank you! As long as you diff the code against the hashbrown code to make sure we match as closely as possible, it should be all good.

It also looks like you should do future changes based off of the newest griddle master branch. It appears you have some commits on your master branch that have probably been squashed on master :)

@jonhoo jonhoo merged commit 029ba5d into jonhoo:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants