chore: rule creation UI changes/additions #1574
Draft
+979
−823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tweaked some margins to align better and more consistently.
benscobie
reviewed
Feb 24, 2025
Comment on lines
+354
to
+357
| onClick={(e) => { | ||
| e.preventDefault() | ||
| props.onOpenHelpModal() | ||
| }} |
There was a problem hiding this comment.
You don't need preventDefault here, set the type to button. By default it'll be type=submit when in a <form>: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type
Suggested change
| onClick={(e) => { | |
| e.preventDefault() | |
| props.onOpenHelpModal() | |
| }} | |
| type="button" | |
| onClick={props.onOpenHelpModal} |
There was a problem hiding this comment.
No way that is the only thing you saw that needed an update/change.
There was a problem hiding this comment.
I haven't finished yet, I started and got tired 😆 . I'll have more of a look soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get this out there so you could take a look. This has been needed for a long time, and I think I am on the right track with the layout.