copy does not preserve file ownership and permissons

[cadorn]

No description provided.

[jprichardson]

Thanks, I will take a look at this on Tuesday or Wednesday.

[jprichardson]

I'm wondering if it may be an issue with the module ncp... AvianFlu/ncp#38 for reference.

[NicolaOrritos]

Hi there.
I found that this issue is not caused by ncp for a certain number of use-cases.
I think that it's not ncp's fault when using fs.copySync(), but I couldn't come up with a test for demonstrating this, though :-(

Nonetheless I came up with a tentative fix.
The fix revolves around propagating the fs.Stats.mode from lib/copy.js to lib/create.js. File stats are to be read within copy.copySync() and then propagated to create.createFileSync().
This one solved the problem for me.

I'll try to write a pull request as well as a test as soon as possible.

[NicolaOrritos]

Oops. I forked it and applied my changes, but it fails the test fs-extra + copySync() > when the source is a directory should should apply filter recursively.

[jprichardson]

Yeah, ncp isn't used for synchronous copy. There is still an active issue with ncp: AvianFlu/ncp#38

[NicolaOrritos]

Any idea why that test is failing? I couldn't understand why my changes triggered an issue with filters.

[jprichardson]

@NicolaOrritos It's not clear to me what issue you're having. The test passes fine. If your issue is different than this one, please open a new issue with a detailed instructions on how to reproduce the error that you're receiving.

Thank you.

[jprichardson]

One step closer: 082aa7f Preserving modes is fixed.

[jprichardson]

Fixed. https://github.com/jprichardson/node-fs-extra/releases/tag/0.22.0

[H8to]

@jprichardson
Hi there, sorry to bump an old issue. I'm trying to find the root cause why Atom text editor, which is using node-fs-extra to copy/duplicate directories, does not preserve the permissions.
This is the issue I'm referring to: tree-view #1218

I gave my best to get an understanding of what happens during the copy-job but phew..
As pentester I do not have deep understanding of programming coffee-script, js or similar.

if (initialPathIsDirectory) {
              results.push(catchAndShowFileErrors((function(_this) {
                return function() {
                  fs.copySync(initialPath, newPath);
                  return _this.emitter.emit('entry-copied', {
                    initialPath: initialPath,
                    newPath: newPath
                  });
                };
              })(this)));

from /usr/lib/atom/node_modules/tree-view/lib/tree-view.js

They seem to use the fs.copySync function which should preserve the permissions as per the changelogs of node-fs-extra:

0.11.1 / 2014-09-02
-------------------
- bugfix `copySync()` preserve file permissions [#80][#80]

Atom makers and I would be thankful for any help!