-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native fs.copyFile and fs.copyFileSync to copy() and copySync() #505
Conversation
IDK what the problem is with travis! @jprichardson @RyanZim do you know what the issue is with travis? |
Restarted the build and it worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tested locally on Node 8 and ensured that the native method is indeed being used in environments that support it without issues.
…nction to util/utimes.js
@jprichardson ping?! |
Looks good. Should be bundled in next major along with |
Ref: #490.
This is based against the
develop
branch.Added native
fs.copyFile
andfs.copyFileSync
tocopy()
andcopySync()
.