Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Checkbox/Radio: Make links inside labels clickable. Addresses #3595 #4665

Merged
merged 2 commits into from
Jul 11, 2012
Merged

Checkbox/Radio: Make links inside labels clickable. Addresses #3595 #4665

merged 2 commits into from
Jul 11, 2012

Conversation

MauriceG
Copy link
Contributor

plus adding some liberal spaces

@ghost ghost assigned jaspermdegroot Jul 10, 2012
jaspermdegroot added a commit that referenced this pull request Jul 11, 2012
@jaspermdegroot
Merge pull request #4665 from MauriceG/patch-11
1b7a8e5 
Checkbox/Radio: Make links inside labels clickable. Addresses #3595
@jaspermdegroot jaspermdegroot merged commit 1b7a8e5 into jquery-archive:master Jul 11, 2012
jaspermdegroot added a commit that referenced this pull request Jul 11, 2012
@jaspermdegroot
Revert "Merge pull request #4665 from MauriceG/patch-11"
c4627d8 
This reverts commit 1b7a8e5, reversing
changes made to ddec464.

This commit broke the checkboxradio unit test.
@jaspermdegroot
Copy link
Contributor

@MauriceG

I had to revert the commit because multiple checkboxradio tests failed after landing this PR.

This could be because we have to rewrite the tests so they match the new situation, but it could also be that allowing links inside the checkbox label/button is causing problems in real.
I didn't see them while testing the fiddle you created, but it requires more investigation. For example, we need to test if the (virtual) events still fire.

To be honest, this doesn't get my highest priority right now, but I won't forget it either!

Jasper

Checkboxradio tests that failed: 1.5 / 4.2 / 4.4 / 8.1

@MauriceG
Copy link
Contributor Author

@uGoMobi

I appreciate your investigation and thanks to take this in (and out).
I'm sorry, I also did not test at local repo :-(
Sorry and thanks also to @johnbender

Maurice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jaspermdegroot jaspermdegroot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceG @jaspermdegroot