Customize preferred quotes #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2016 22:02
* js2-refactor.el (js2-refactor): Add customization group for the package. * (js2r-use-strict): Refactor the variable as a customizeable option.
* js2-refactor.el (js2r-preferred-quote-type): Add a preferred quotes style option. * js2r-helpers.el (js2r--wrap-text-with-preferred-quotes): Add a helper function to wrap text with preferred quotes. (js2r--wrap-text): Add a shorter name for convenience. * js2r-conveniences.el (js2r-log-this): (js2r-debug-this): Add preferred quotes suppport.
NicolasPetton
requested changes
Oct 14, 2016
| (setq prefered-quotes "'")) | ||
| (concat prefered-quotes (apply 'concat text) prefered-quotes))) | ||
|
|
||
| (defalias 'js2r--wrap-text 'js2r--wrap-text-with-prefered-quotes) |
There was a problem hiding this comment.
Why a defalias? Why not just name it js2r--wrap-text?
There was a problem hiding this comment.
This was because I found js2r--wrap-text-with-prefered-quotes to be too long to fit inside the js2r--figure-out-what-to-log-where. I'll definitely change it.
NicolasPetton
approved these changes
Oct 19, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the log this is a nice functionality. However, the only quote style supported is using double quotes (
"). This can be quite bothering if someone uses a linter that forbids the use of quotes style.Those patches fix this problem