Pin isort to restore the lint step in CI #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#290 shows a failure in the lint step (all the actual tests pass ok). The root cause seems to be a recent release of isort (5.0) which affects nblint and pylint. Until both have migrated to isort 5.0 the proposed solution is to pin isort <5.
Upstream/root issues:
Code changes
Pin isort in:
User-facing changes
None
Backwards-incompatible changes
None
Chores